optimize account creation and verification

backend/src/test/java/com/krrishg/controller/AuthControllerTest.java

@@ -52,8 +52,6 @@ class AuthControllerTest {
 
         RegisterRequest request = new RegisterRequest();
         request.setEmail("test@example.com");
-        request.setPassword("password123");
-        request.setName("Test");
 
         mockMvc.perform(post("/api/auth/register")
                         .contentType(MediaType.APPLICATION_JSON)
@@ -218,6 +216,7 @@ class AuthControllerTest {
         SetPasswordRequest request = new SetPasswordRequest();
         request.setSetupToken("setup-token-123");
         request.setPassword("new-password");
+        request.setName("Test");
 
         mockMvc.perform(post("/api/auth/set-password")
                         .contentType(MediaType.APPLICATION_JSON)
@@ -233,6 +232,7 @@ class AuthControllerTest {
         SetPasswordRequest request = new SetPasswordRequest();
         request.setSetupToken("bad-token");
         request.setPassword("new-password");
+        request.setName("Test");
 
         mockMvc.perform(post("/api/auth/set-password")
                         .contentType(MediaType.APPLICATION_JSON)

backend/src/test/java/com/krrishg/service/AuthServiceTest.java

@@ -43,8 +43,6 @@ class AuthServiceTest {
     void registerCreatesUserAndSendsVerification() {
         RegisterRequest request = new RegisterRequest();
         request.setEmail("new@example.com");
-        request.setPassword("password123");
-        request.setName("New User");
 
         RegistrationResponse response = authService.register(request);
 
@@ -53,12 +51,21 @@ class AuthServiceTest {
         assertFalse(userRepository.findByEmail("new@example.com").get().isEmailVerified());
     }
 
+    @Test
+    void registerDoesNotSetName() {
+        RegisterRequest request = new RegisterRequest();
+        request.setEmail("noname@example.com");
+
+        authService.register(request);
+
+        User user = userRepository.findByEmail("noname@example.com").get();
+        assertNull(user.getName());
+    }
+
     @Test
     void registerSendsVerificationEmail() {
         RegisterRequest request = new RegisterRequest();
         request.setEmail("emailtest@example.com");
-        request.setPassword("password123");
-        request.setName("Email Test");
 
         authService.register(request);
 
@@ -79,8 +86,6 @@ class AuthServiceTest {
 
         RegisterRequest request = new RegisterRequest();
         request.setEmail("verified@example.com");
-        request.setPassword("password123");
-        request.setName("Should Not Matter");
 
         RegistrationResponse response = authService.register(request);
 
@@ -100,8 +105,6 @@ class AuthServiceTest {
 
         RegisterRequest request = new RegisterRequest();
         request.setEmail("unverified@example.com");
-        request.setPassword("newpassword");
-        request.setName("New Name");
 
         RegistrationResponse response = authService.register(request);
 
@@ -114,8 +117,6 @@ class AuthServiceTest {
     void registerNormalizesEmailCase() {
         RegisterRequest request = new RegisterRequest();
         request.setEmail("UpperCase@Example.com");
-        request.setPassword("password123");
-        request.setName("User");
 
         authService.register(request);
 
@@ -126,11 +127,10 @@ class AuthServiceTest {
     void loginWithValidCredentialsAndVerifiedEmailReturnsTokens() {
         RegisterRequest reg = new RegisterRequest();
         reg.setEmail("login@example.com");
-        reg.setPassword("password123");
-        reg.setName("Login User");
         authService.register(reg);
 
         User user = userRepository.findByEmail("login@example.com").get();
+        user.setPassword("{stub}password123");
         user.setEmailVerified(true);
         userRepository.save(user);
 
@@ -149,8 +149,6 @@ class AuthServiceTest {
     void loginThrowsWhenEmailNotVerified() {
         RegisterRequest reg = new RegisterRequest();
         reg.setEmail("unverified@example.com");
-        reg.setPassword("password123");
-        reg.setName("Unverified");
         authService.register(reg);
 
         LoginRequest login = new LoginRequest();
@@ -166,11 +164,10 @@ class AuthServiceTest {
     void loginThrowsOnWrongPassword() {
         RegisterRequest reg = new RegisterRequest();
         reg.setEmail("wrongpw@example.com");
-        reg.setPassword("correctpw");
-        reg.setName("User");
         authService.register(reg);
 
         User user = userRepository.findByEmail("wrongpw@example.com").get();
+        user.setPassword("{stub}correctpw");
         user.setEmailVerified(true);
         userRepository.save(user);
 
@@ -315,11 +312,13 @@ class AuthServiceTest {
         SetPasswordRequest request = new SetPasswordRequest();
         request.setSetupToken("setup-token-123");
         request.setPassword("new-password");
+        request.setName("New Name");
 
         authService.setPassword(request);
 
         User updatedUser = userRepository.findById(user.getId()).get();
         assertTrue(updatedUser.getPassword().contains("new-password"));
+        assertEquals("New Name", updatedUser.getName());
 
         VerificationToken updatedToken = tokenRepository.findByToken("verify-token").get();
         assertTrue(updatedToken.isSetupTokenUsed());
@@ -480,8 +479,6 @@ class AuthServiceTest {
     void refreshTokenReturnsNewTokens() {
         RegisterRequest reg = new RegisterRequest();
         reg.setEmail("refresh@example.com");
-        reg.setPassword("password123");
-        reg.setName("Refresh User");
         authService.register(reg);
 
         User user = userRepository.findByEmail("refresh@example.com").get();